2017-08-08 19:52:15 +00:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
|
|
class ActivityPub::Activity::Block < ActivityPub::Activity
|
|
|
|
|
def perform
|
|
|
|
|
target_account = account_from_uri(object_uri)
|
|
|
|
|
|
Fix not handling Undo on some activity types when they aren't inlined (#14346)
* Fix not handling Undo on some activity types when they aren't inlined
When receiving an Undo for a non-inlined activity, try looking it up in
database using the URI. The queries are ad-hoc because we don't have a global
index of object URIs, and not all activity types are stored in database with
an index on their URI.
Announces are just statuses, and have an index on URIs, so this check can
be done efficiently.
Accepts cannot be handled at all because we don't record their URI at any
point.
Follows don't have an index on URI, but they have an index on the issuing
account, which should make such queries largely manageable.
Likes don't have an index on URI, they have an index on the issuing account,
but the number of favs per account may be very high, so I decided not to
handle that.
Blocks don't have an index on URI, but they have an index on the issuing
account, which should make such queries largely manageable.
In all cases, if an Undo could not be handled properly, we call `delete_later!`
because that does not require us to know more than the URI of the undone
property.
* Add tests
* Make newer blocks overwrite older ones
Allows re-synchronizing block info by re-blocking and un-blocking again
when the original Undo Block has been lost.
2020-07-22 09:45:35 +00:00
|
|
|
return if target_account.nil? || !target_account.local?
|
|
|
|
|
|
|
|
|
|
if @account.blocking?(target_account)
|
|
|
|
|
@account.block_relationships.find_by(target_account: target_account).update(uri: @json['id']) if @json['id'].present?
|
|
|
|
|
return
|
|
|
|
|
end
|
2017-08-08 19:52:15 +00:00
|
|
|
|
|
|
|
|
UnfollowService.new.call(target_account, @account) if target_account.following?(@account)
|
2019-01-02 00:12:02 +00:00
|
|
|
|
|
|
|
|
@account.block!(target_account, uri: @json['id']) unless delete_arrived_first?(@json['id'])
|
2017-08-08 19:52:15 +00:00
|
|
|
end
|
|
|
|
|
end
|
